You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since access to the Mailgun API key is required, only members of the @nodejs/build-infra team have the permission to push code to the `main` branch. That was done in order to minimize the possibility of mismatches between the information in this repo, and the actual email routes that are set up.
I'm not sure what requirements are missing to merge. I would have to tick "Merge without waiting for requirements to be met (bypass rules)" to do it.
+1 I'm seeing the same issue in #280 and plan to merge it, as it looks like a straightforward change. It also seems that we're bypassing the rules fairly often (ref).
I believe the original intention was to restrict merging to @nodejs/build-infra members, since changes need to be manually triggered. This also reminds me of the automation proposal in #222, though that would require a deeper discussion around handling production secrets in public GitHub Actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes sharing portion of the README much more readable:
Before:
email/README.md
Line 20 in 71bb6a0
After:
email/README.md
Lines 21 to 24 in 2fa47a6